-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/loginpage : 로그인페이지 퍼블리싱 및 버그픽스 #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!
client/src/pages/Login.tsx
Outdated
.post("http://localhost:4000/auth/login", { | ||
userId: userId, | ||
password: password, | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shorthand 형식으로 작성하셔도 괜찮을 것 같습니다
axios
.post("http://localhost:4000/auth/login", {
userId,
password,
})
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저게 되는군요 ㄷㄷ
if (!/^[a-zA-Z0-9]*$/g.test(id)) return "영문 대소문자, 숫자만 입력이 가능합니다"; | ||
return "ID는 6자 이상 20자 이하여야 합니다"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
감사합니다🙇♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Feature
로그인페이지 퍼블리싱
작업내용
div
구조상cursor pointer
가 전체에 걸려있어서 글자가 아닌 부분에도 클릭하면 반응했는데,글자에만 클릭되도록 수정했습니다
InputValidator
버그를 수정했습니다 (Input validator 버그 #33)first-child
에서:not(:last-child)
로 변경했습니다비밀번호를 한번 더 입력하세요
->비밀번호가 일치하지 않습니다
결과 (스크린샷 등)
관련 issue 번호 (링크)
테스트 방법
Commit